test: integration test storage-types #1762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetzweg
requested review from
cmichi,
ascjones,
HCastano and
SkymanOne
as code owners
This was referenced Apr 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #1762 +/- ##
==========================================
- Coverage 70.86% 70.84% -0.02%
==========================================
Files 207 207
Lines 6655 6655
==========================================
- Hits 4716 4715 -1
- Misses 1939 1940 +1 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
the approach of the Mother contract where it returns the input values was ok imo. it allows us to test the encoding of user inputs as well. why do you think it's a problem if we test them together? |
statictype
reviewed
May 9, 2023
…ned by an ink message, therefore there is nothing to be tested regarding decoding.
|
we could replace Mother with this. wdyt @agryaznov ? |
…ned by an ink message, therefore there is nothing to be tested regarding decoding.
…paritytech/ink into peetzweg-integration-test-storage_types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The origin of this PR is the need in the
contracts-uirepo to have a contract to test the proper decoding and display of return values of an ink smart contract.We currently have integration test using the
mothercontract, however, it's missing some possible types and is relying on inputs for some messages. Testing encoding and sending inputs to an ink! message is should be tested separately.The original development of this contract happened in a pr for the ink-examples repo before I realised it was a mirror of
ink/intergration-testsfolder.Related
ink-examplesPR: use-ink/ink-examples#15Related
contracts-uiPR: use-ink/contracts-ui#470cc @statictype